Updating issue templates again for rustbot #7627
Conversation
|
r? @llogiq (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
xFrednet
force-pushed
the
0000-updating-issue-templates-again
branch
2 times, most recently
from
cb0ff25 to
0875445
Compare
|
Why not surround the whole commad in backticks? I'm sure people will know to remove them. Or does that have the same issue? |
|
The issue is that GitHub ignores backticks inside comments. At least rustbot still triggers with them. I'll ping you inside an HTML comment with backticks as an example |
|
Well now it's somehow not triggering rustbot with the backticks. Maybe I missed that in my tests earlier |
|
You're right, nice catch! Thank you! |
xFrednet
force-pushed
the
0000-updating-issue-templates-again
branch
from
0875445 to
169aea6
Compare
|
From my side, this looks Ok. r=me if you think it's ready to merge. |
|
@bors r=llogiq |
|
📌 Commit 169aea6 has been approved by |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
It turns out that our current issue template can sometimes trigger a rustbot error message, as can be seen in #7626. I originally tested this in #7599, but it's apparently a bit inconsistent. This PR adds backticks to the commands, as correctly suggested by @mikerite in the comments. (Thank you!)
@rustbot label +S-blockedNow I also pushed a tiny link fix as well. 🙃
changelog: none